-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent double waitgroup decrement #10170
Merged
zeripath
merged 6 commits into
go-gitea:master
from
zeripath:prevent-double-wg-decrement
Feb 7, 2020
Merged
Prevent double waitgroup decrement #10170
zeripath
merged 6 commits into
go-gitea:master
from
zeripath:prevent-double-wg-decrement
Feb 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillep2k
approved these changes
Feb 6, 2020
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Feb 6, 2020
lafriks
approved these changes
Feb 6, 2020
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Feb 6, 2020
guillep2k
reviewed
Feb 6, 2020
zeripath
commented
Feb 6, 2020
zeripath
commented
Feb 6, 2020
zeripath
commented
Feb 6, 2020
lafriks
approved these changes
Feb 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #10170 +/- ##
==========================================
+ Coverage 43.41% 43.43% +0.01%
==========================================
Files 576 576
Lines 79642 79642
==========================================
+ Hits 34580 34590 +10
+ Misses 40786 40777 -9
+ Partials 4276 4275 -1
Continue to review full report at Codecov.
|
guillep2k
approved these changes
Feb 6, 2020
The tests that failed before the latest commit ( |
guillep2k
pushed a commit
to guillep2k/gitea
that referenced
this pull request
Feb 7, 2020
* Prevent double waitgroup decrement
zeripath
added a commit
that referenced
this pull request
Feb 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user in discourse has discovered that under heavy loads it is possible to cause a double decrement in the server connection waitgroup.
This PR prevents this.